search

rainyl / opencv_dart

OpenCV bindings for Dart language and Flutter. Support Asynchronous Now!
https://pub.dev/packages/opencv_dart
Apache License 2.0
138 stars 18 forks source link

fix imencode interface #168

Closed abdelaziz-mahdy closed 4 months ago

abdelaziz-mahdy commented 4 months ago

fix: https://github.com/rainyl/opencv_dart/issues/166 hope i have done it correctly

rainyl commented 4 months ago

@abdelaziz-mahdy Looks good, just need some minor changes.

abdelaziz-mahdy commented 4 months ago

Nice, do you think a tool to match the interface to python one is an option?

Like extracts the python interface and try to match it ? Using dart types of course to ensure we don't break any interface when making new apis

And that same tool should check if the async one matches the sync ones

I think it will be a lot of work but it will make sure the interfaces are the same and sync and async are the same

rainyl commented 4 months ago

Nice, do you think a tool to match the interface to python one is an option?

Like extracts the python interface and try to match it ? Using dart types of course to ensure we don't break any interface when making new apis

And that same tool should check if the async one matches the sync ones

I think it will be a lot of work but it will make sure the interfaces are the same and sync and async are the same

Sounds interesting, maybe we can discuss it in a new issue.