rainyl / opencv_dart

OpenCV bindings for Dart language and Flutter. Support Asynchronous Now!
https://pub.dev/packages/opencv_dart
Apache License 2.0
136 stars 18 forks source link

adding size comparison #277

Closed abdelaziz-mahdy closed 3 weeks ago

abdelaziz-mahdy commented 3 weeks ago

fixes https://github.com/rainyl/opencv_dart/issues/276

dont know what the best way to show it , i was thinking of creating a svg to show it in readme which will make it look good and easily updatable

added svg generation and it gets pushed into the artifacts (if you like this idea we can make the svgs gets pushed to github and then show it in the readme)

abdelaziz-mahdy commented 3 weeks ago

this is an example svg that can be generated

image

if you want to edit the readme using the script instead of the svg let me know

Note: android was wrong here and i pushed a fix for it

rainyl commented 3 weeks ago

this is an example svg that can be generated image

Wow, looks soooo great! πŸŽ‰

if you want to edit the readme using the script instead of the svg let me know

maybe we can save the generated svg to images/ directory and add a section in README to show it?

abdelaziz-mahdy commented 3 weeks ago

this is an example svg that can be generated image

Wow, looks soooo great! πŸŽ‰

if you want to edit the readme using the script instead of the svg let me know

maybe we can save the generated svg to images/ directory and add a section in README to show it?

That will work yes, and we can show each package svg in it's readme

rainyl commented 3 weeks ago

That will work yes, and we can show each package svg in it's readme

Cool!

abdelaziz-mahdy commented 3 weeks ago

Will do it tomorrow, since it's late for meπŸ˜…

rainyl commented 3 weeks ago

Will do it tomorrow, since it's late for meπŸ˜…

Just do it when you are free~ I noticed that you have spent a lot of time on this. goodnight ~ πŸ›Œ

abdelaziz-mahdy commented 3 weeks ago

i think its correct but the commit is failing

abdelaziz-mahdy commented 3 weeks ago

i added full apk size comparison too, and for the commit problem i made the workflow work on my branch and it works correctly, also i added them to the readme

let me know if there is anything that needs to be added or updated

codecov-commenter commented 3 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.03%. Comparing base (580213b) to head (f9b3256).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #277 +/- ## ======================================= Coverage 92.03% 92.03% ======================================= Files 49 49 Lines 9129 9129 ======================================= Hits 8402 8402 Misses 727 727 ``` | [Flag](https://app.codecov.io/gh/rainyl/opencv_dart/pull/277/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rainy+liu) | Coverage Ξ” | | |---|---|---| | [unittests](https://app.codecov.io/gh/rainyl/opencv_dart/pull/277/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rainy+liu) | `92.03% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rainy+liu#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rainyl commented 3 weeks ago

i added full apk size comparison too, and for the commit problem i made the workflow work on my branch and it works correctly, also i added them to the readme

let me know if there is anything that needs to be added or updated

Great! I extracted the python scripts to reduce the length of the workflow.

Looks good to me now.

abdelaziz-mahdy commented 3 weeks ago

i added full apk size comparison too, and for the commit problem i made the workflow work on my branch and it works correctly, also i added them to the readme

let me know if there is anything that needs to be added or updated

Great! I extracted the python scripts to reduce the length of the workflow.

Looks good to me now.

I wanted to do it but was not finding a good location for them πŸ˜…πŸ˜…

Glad you did it.

rainyl commented 3 weeks ago

Merged, thanks for your efforts! πŸŽ‰ @abdelaziz-mahdy