rainyl / opencv_dart

OpenCV bindings for Dart language and Flutter. Support Asynchronous Now!
https://pub.dev/packages/opencv_dart
Apache License 2.0
137 stars 18 forks source link

Fix: minEnclosingCircle #285

Closed rainyl closed 2 weeks ago

rainyl commented 3 weeks ago

fix: #284 #282

codecov-commenter commented 3 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.03%. Comparing base (c904dcf) to head (ac3ad40).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #285 +/- ## ======================================= Coverage 92.03% 92.03% ======================================= Files 49 49 Lines 9129 9129 ======================================= Hits 8402 8402 Misses 727 727 ``` | [Flag](https://app.codecov.io/gh/rainyl/opencv_dart/pull/285/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rainy+liu) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/rainyl/opencv_dart/pull/285/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rainy+liu) | `92.03% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rainy+liu#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rainyl commented 3 weeks ago

Unable to strip library '.../build/app/intermediates/merged_native_libs/release/out/lib/armeabi-v7a/libdartcv.so' due to missing strip tool for ABI 'ARMEABI_V7A'. Packaging it as is.

It's because the ndk used to strip not exists, maybe we should specify the ndk version in opencv_core/android/build.gradle

rainyl commented 3 weeks ago

android.ndkVersion is unavailable in android/build.gradle when building the example... I think it's a bug of Flutter or gradle.

abdelaziz-mahdy commented 3 weeks ago

wow thats a very nice reduction of the package size

abdelaziz-mahdy commented 3 weeks ago

btw do you know how to reduce windows and linux package sizes too? specially for the opencv_dart one like a minimal version of ffmpeg

rainyl commented 2 weeks ago

btw do you know how to reduce windows and linux package sizes too? specially for the opencv_dart one like a minimal version of ffmpeg

FFMPEG for windows and linux are downloaded from https://github.com/rainyl/FFmpeg-Builds/releases , so it's necessary to configure the build flags properly if we want to reduce the size of ffmpeg.