rainyl / opencv_dart

OpenCV bindings for Dart language and Flutter.
https://pub.dev/packages/opencv_dart
Apache License 2.0
78 stars 10 forks source link

Run on emulator (ci) #80

Closed abdelaziz-mahdy closed 2 weeks ago

abdelaziz-mahdy commented 3 weeks ago

a ci to test on emulator, to make sure the problem is not only on my machine and to make sure it works for other people too

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.03%. Comparing base (a763082) to head (6a54d99).

:exclamation: Current head 6a54d99 differs from pull request most recent head 99f5c56

Please upload reports for the commit 99f5c56 to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #80 +/- ## ======================================= Coverage 90.03% 90.03% ======================================= Files 36 36 Lines 5277 5277 ======================================= Hits 4751 4751 Misses 526 526 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abdelaziz-mahdy commented 3 weeks ago

ios failed same as my case, which is weird since flutter should auto run pod install :), android simulator failed to run, but i think android doesnt have a problem so we can ignore it

rainyl commented 3 weeks ago

thanks,i will test it later :)

rainyl commented 3 weeks ago

Well, now it success, maybe you forgot to install build dependencies?

abdelaziz-mahdy commented 3 weeks ago

Well, now it success, maybe you forgot to install build dependencies?

In my local machine, The build dep are there, since it worked when I ran pod install (the build worked)

Will check if I can add a detailed error to help other people

But setting the arch looks like it works, still if a universal framework can be achieved without increasing the size, well that will be the best option

the only thing i found is https://github.com/rainyl/opencv_dart/blob/a763082a36acfda20782fc3b0f84c0ab9b4d95e6/profiles/ios.toolchain.cmake#L61 dont know if its enabled or not, but i think that will be easier for future development? (note i dont understand it fully but looks like its the general option for our case) but does opencv build support it is the real question i cant figure out

rainyl commented 3 weeks ago

But setting the arch looks like it works, still if a universal framework can be achieved without increasing the size, well that will be the best option

Absolutely agree.

dont know if its enabled or not, but i think that will be easier for future development? (note i dont understand it fully but looks like its the general option for our case) but does opencv build support it is the real question i cant figure out

I will take a look at it.

rainyl commented 2 weeks ago

@abdelaziz-mahdy I have published v1.0.6 with universal framework supported, could you please test whether it works on your devices?

abdelaziz-mahdy commented 2 weeks ago

@abdelaziz-mahdy I have published v1.0.6 with universal framework supported, could you please test whether it works on your devices?

i failed to test due to https://github.com/rainyl/opencv_dart/issues/86 will wait for a fix then try again

abdelaziz-mahdy commented 2 weeks ago

i dont think this is needed anymore, reopen if its needed

rainyl commented 2 weeks ago

😺

abdelaziz-mahdy commented 2 weeks ago

😺

i love cats, but i didnt understand it in this context 😂

rainyl commented 2 weeks ago

hhhhh, just same as 😃 but a cat version.