raiozhang / oauth-dot-net

Automatically exported from code.google.com/p/oauth-dot-net
0 stars 0 forks source link

OAuthRequestToken.OAuthParameters reference equality issue #24

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Any kind of comparision of 2 OAuthRequestToken objects
2.
3.

What is the expected output? What do you see instead?
When comparing 2 OAuthRequestToken objects, Equals should evaluate to true
if the AssociatedParameters values are identical, even if they are not the
same object (assuming all other fields/properties are identical). But since
it uses a reference comparison to evaluate this, the objects will always
evaluate to not equal if the object. This refers to the OAuthRequestToken,
which, when checking equality of the OAuthParameters object, uses the
default Equals method. This is not overridden to provide value checking
rather than reference checking.

What version of the product are you using? On what operating system?
0.7.1.0

Please provide any additional information below.
This would be a problem if the OAuthRequestToken objects were re-created
from a data store, rather just set aside in memory, as with the InMemory
stores that are provided with the framework.

Original issue reported on code.google.com by Samuel.D...@gmail.com on 2 Mar 2010 at 2:03