UseSQLiteStorage: wrong argument name - nameOrConnectionString

raisedapp / Hangfire.Storage.SQLite

An Alternative SQLite Storage for Hangfire

https://www.nuget.org/packages/Hangfire.Storage.SQLite

MIT License

155 stars 31 forks source link

UseSQLiteStorage: wrong argument name - nameOrConnectionString #27

Closed petarpetrovt closed 3 years ago

petarpetrovt commented 4 years ago

Extension method UseSQLiteStorage has a argument named nameOrConnectionString but the sqlite-net library's SQLiteConnection takes databasePath as argument.

Doesn't work

UseSQLiteStorage($"Data Source={pathToDbFile};Version=3;")
UseSQLiteStorage("Hangfire")

Works

UseSQLiteStorage(pathToDbFile)

felixclase commented 3 years ago

The change has already been implemented, I will be publishing the new version.

aradalvand commented 1 year ago

@felixclase Sorry, I'm still seeing the old argument name?! It doesn't seem to have changed: https://github.com/raisedapp/Hangfire.Storage.SQLite/blob/65c37b8bf1d8a901312b273342a57000b5c600c7/src/main/Hangfire.Storage.SQLite/SQLiteStorageExtensions.cs#L37-L40