search

raisedapp / Hangfire.Storage.SQLite

An Alternative SQLite Storage for Hangfire
https://www.nuget.org/packages/Hangfire.Storage.SQLite
MIT License
155 stars 31 forks source link

Previously merged PRs have disappeared #60

Closed mlaily closed 9 months ago

mlaily commented 1 year ago

Hello!

I sent a few pull requests a few months ago. (https://github.com/raisedapp/Hangfire.Storage.SQLite/pull/55 https://github.com/raisedapp/Hangfire.Storage.SQLite/pull/54 https://github.com/raisedapp/Hangfire.Storage.SQLite/pull/53)

I think you ended up merging them, but I don't see them anymore in any branch.
image

Is that a mistake or did you erase these commits on purpose?

I still think the changes I suggested are useful, and I'd very like them to be released in an official version, so I'm submitting them again in the present PR 🙂

(The branch contains the three PRs I mentioned earlier, taking into account the changes you did on develop since then, so it can merge cleanly)

Please let me know what you think!

felixclase commented 1 year ago

The changes were not deleted, I was testing those changes and they were not working correctly. I am integrating them little by little and validating that everything is ok before releasing a new version with them.

mlaily commented 1 year ago

Oh ok. It was strange to me to see the PRs as merged but with the code not in any branch I could find!

I hope that in time, you will be able to bring them all back!

Out of curiosity, what kind of problem did you have with the changes? I'm using a custom version with them in a project that has been running without much problem since december.