search

raisedragon / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

PircBotx#getChannel(String string) does not support case insensitivity #144

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Add a channel e.g. Channel
2. call PircBotx#getChannel("#channel") <-- notice case sensitivity

What is the expected output? What do you see instead?

Expected to get channel #Channel. Instead get new channel #channel

What version of the product are you using? On what operating system?

1.9. Windows 7 x64

Please provide any additional information below.

The 'PircBotx#getChannel(String string)' method should be changed. Rather than 
using 'equals', use equalsIgnoreCase because IRC by definition is case 
insensitive.

if (curChan.getName().equalsIgnoreCase(name))
                return curChan;

Original issue reported on code.google.com by jely.chr...@gmail.com on 1 Oct 2013 at 8:28

GoogleCodeExporter commented 9 years ago 
Well 2.0 has moved user and channel handling to UserChannelDao. This makes 
sense though, changed in Revision 8c8268c0cb47.

Original comment by Lord.Qua...@gmail.com on 10 Oct 2013 at 3:00