Cleanup creation of Channel's and Users

raisedragon / pircbotx

Automatically exported from code.google.com/p/pircbotx

0 stars 0 forks source link

Cleanup creation of Channel's and Users #148

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

If i perform a who on a nick or a nickmask ( /WHO nic* ), pircbotx's channel 
list get poluted with both nicks and channels that pircbotx is not joined due 
to insufficient checks in the response parser.

I have attached a patch that solves it for pirxbotx 1.9,

Original issue reported on code.google.com by hoerup1...@gmail.com on 23 Oct 2013 at 8:03

Blocking: #177, #181

Attachments:

pircbot19_rpl_who.diff

GoogleCodeExporter commented 9 years ago

And looking at current source the same issue is present in pircbotx 2.0 
InputParser.java

Original comment by hoerup1...@gmail.com on 23 Oct 2013 at 8:08

GoogleCodeExporter commented 9 years ago

[deleted comment]

GoogleCodeExporter commented 9 years ago

Added a patch for current InputParser test to validate against.

Original comment by hoerup1...@gmail.com on 18 Nov 2013 at 8:23

Attachments:

pircbotx2_whotest.diff

GoogleCodeExporter commented 9 years ago

Due to how I'm going to fix this, I'm pushing this back to 2.1. Your patch 
risks confusion since the Channel object isn't attached to the UserChannelDao. 
Many of its methods won't work anymore since they query the DAO.

I'm probably going to split WhoEvent into WhoChannelEvent with String channel 
name + getter for channel object and WhoUserEvent with most likely 
UserChannelMapSnapshot. 

Let me get the 2.0.1 bugfix release out the door first

Original comment by Lord.Qua...@gmail.com on 19 Nov 2013 at 5:57

Changed state: Started
Added labels: target-2.1

GoogleCodeExporter commented 9 years ago

Any progress on this one ?

Original comment by hoerup1...@gmail.com on 26 Feb 2014 at 5:57

GoogleCodeExporter commented 9 years ago

Original comment by Lord.Qua...@gmail.com on 28 May 2014 at 3:59

Changed title: Cleanup creation of Channel's and Users
Added labels: Priority-High
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

Original comment by Lord.Qua...@gmail.com on 28 May 2014 at 4:00

Now blocking: #177

GoogleCodeExporter commented 9 years ago

Original comment by Lord.Qua...@gmail.com on 16 Jul 2014 at 5:37

Now blocking: #181

GoogleCodeExporter commented 9 years ago

Issue 188 has been merged into this issue.

Original comment by Lord.Qua...@gmail.com on 22 Jul 2014 at 3:23

GoogleCodeExporter commented 9 years ago

Original comment by Lord.Qua...@gmail.com on 8 Aug 2014 at 5:10

Now blocking: #186

GoogleCodeExporter commented 9 years ago

Original comment by Lord.Qua...@gmail.com on 31 Oct 2014 at 2:41

GoogleCodeExporter commented 9 years ago

Finally finished in the latest snapshot

Original comment by Lord.Qua...@gmail.com on 31 Oct 2014 at 3:39

Changed state: Fixed