raisedragon / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

User.isVerified() does not work #180

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a bot that checks if a user is verified and let it print to standard 
output

What is the expected output? What do you see instead?
true if the user is verified by nickserv, false if not

I checked a user (me) who has been verified using Nickserv whether he was 
verified. User.isVerified() returned false, even though the User actually was 
verified.

What version of the product are you using? On what operating system?
2.0.1 on Linux (openSuSE 13.1)

Original issue reported on code.google.com by itsMEE.Minecraft on 13 Jun 2014 at 6:51

GoogleCodeExporter commented 9 years ago
What's the output of /WHOIS yourusername yourusername  

Original comment by Lord.Qua...@gmail.com on 13 Jun 2014 at 7:06

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[itsmee] WHOIS itsmee
[itsmee] [server hostname] (Freier IRC-Server)
[itsmee] +#advgo #dev
[itsmee] is a registered nick
[itsmee] is connecting from *@[Hostname] [IP]
[itsmee] idle: 00 hours 01 minute 18 seconds, signon at: Fr, 13 Jun 2014 
20:44:13
[itsmee] End of WHOIS list

Original comment by itsMEE.Minecraft on 16 Jun 2014 at 6:52

GoogleCodeExporter commented 9 years ago
This is working for me on both Freenode and SwiftIRC (UnrealIRCD). Try the 
latest snapshot

Original comment by Lord.Qua...@gmail.com on 17 Jul 2014 at 1:03

GoogleCodeExporter commented 9 years ago

Original comment by Lord.Qua...@gmail.com on 17 Jul 2014 at 1:13

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Tested on ngIRCd. Doesn't work. It doesn't work for me on freenode 
(kornbluth.freenode.net  (DE)) either with version 2.0.1 (Maven) of PircBotX 
and today's (17th of July 2014) default-branch from google code.

Original comment by itsMEE.Minecraft on 17 Jul 2014 at 12:36

GoogleCodeExporter commented 9 years ago
I have no idea about Freenode, it works for me

if (event.getMessage().startsWith("?isverified"))
    event.respond(""+event.getUser().isVerified());

Me: PRIVMSG #pircbotx :?isverified
Bot: PRIVMSG #pircbotx :TheLQ: true
Me: nickserv logout
Nickserv: NOTICE TheLQ :You have been logged out.
Me: PRIVMSG #pircbotx :?isverified
PircBotX: PRIVMSG #pircbotx :TheLQ: false

Your bot logs should look something like what's attached (note the 330 line the 
first time and how it's missing the second time). On some servers it's 307. If 
you see see a different code, please tell me what it is.

Do you have a public ngIRCd server I can test?

Original comment by Lord.Qua...@gmail.com on 7 Aug 2014 at 3:37

Attachments:

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
It's not actually <public>. I tested it, and I got this:

(verified)
[listenerPool0-thread4] INFO org.pircbotx.output.OutputRaw - WHOIS manybot 
manybot
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 311 AdventuriaJin0 
manybot ~manybot Hakase * :manybot
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 312 AdventuriaJin0 
manybot [server hostname] :Freier IRC-Server
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 319 AdventuriaJin0 
manybot :+#advgo @#dev
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 307 AdventuriaJin0 
manybot :is a registered nick
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 317 AdventuriaJin0 
manybot 1 1403102397 :seconds idle, signon time
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 318 AdventuriaJin0 
manybot :End of WHOIS list

Versus:

(not verified)
[listenerPool0-thread6] INFO org.pircbotx.output.OutputRaw - WHOIS manybot 
manybot
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 311 AdventuriaJin0 
manybot ~manybot Hakase * :manybot
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 312 AdventuriaJin0 
manybot [server hostname] :Freier IRC-Server
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 319 AdventuriaJin0 
manybot :+#advgo @#dev
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 317 AdventuriaJin0 
manybot 0 1403102397 :seconds idle, signon time
[Thread-2] INFO org.pircbotx.InputParser - :irc.sub-r.de 318 AdventuriaJin0 
manybot :End of WHOIS list

Original comment by itsMEE.Minecraft on 8 Aug 2014 at 2:33

GoogleCodeExporter commented 9 years ago
I'm sorry about this. I reverted my repo back to 2.0.1 and discovered 307 
handling wasn't implemented. Turns out it wasn't until Revision 4d75e2d5ecb6 
that it was added. 

Update to the latest snapshot. I tested with it and it works. 

Once again I apologize, that completely slipped my mind.

Original comment by Lord.Qua...@gmail.com on 31 Aug 2014 at 7:41

GoogleCodeExporter commented 9 years ago
Issue 183 has been merged into this issue.

Original comment by Lord.Qua...@gmail.com on 31 Aug 2014 at 8:13