Closed GoogleCodeExporter closed 9 years ago
What are the log lines before this?
Original comment by Lord.Qua...@gmail.com
on 4 Jan 2015 at 1:53
The line before it is a command being executed. If you're requesting a full
reproducible log, I'll have to provide it tomorrow. The command being run is
&say tacocat smells. tacocat being a user in the channel I was executing the
command. The bots source is on github. http//github.com/TechCavern/WaveTact
Original comment by jzhou2...@gmail.com
on 4 Jan 2015 at 2:31
https://gist.github.com/jztech101/cc721d4a091b45adbb4e Full log
Original comment by jzhou2...@gmail.com
on 4 Jan 2015 at 5:09
I knew ReplayServer would come in handy someday!
I converted your log into the ReplayServer format and guessed your
implementation. Both files are attached. I can't seem to reproduce it though,
the MessageEvent channel is correct, the WhoisEvent channels are correct, and
the bot responds to everything correctly.
Are you sure your getting the right value?
Original comment by Lord.Qua...@gmail.com
on 5 Jan 2015 at 8:28
Attachments:
I'm afraid I'm failing to see where you are using getUserChannelDao.
getChannel(). Perhaps I have worded the issue incorrectly. I am try to get the
channel if there is one as the first parameter. However if I enter a user as
the first parameter it throws then forementioned error instead of returning null
Original comment by jzhou2...@gmail.com
on 5 Jan 2015 at 12:30
Ohhhh.... sorry the way you worded it sounded like PircBotX was returning a
user as a channel
getChannel and getUser will now throw an exception instead of returning null
and causing unexpected and difficult to debug NPEs. This also keeps the
original contract where they never returned nulls.
This was already documented in the changelog, although the UserChannelDao
methods barely have any javadoc.
Original comment by Lord.Qua...@gmail.com
on 5 Jan 2015 at 4:02
Fixed in Revision 0fb15122183b
Original comment by Lord.Qua...@gmail.com
on 12 Jan 2015 at 4:13
Original issue reported on code.google.com by
jzhou2...@gmail.com
on 3 Jan 2015 at 9:37