search

raisedragon / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

Fix Channel mode is stale warning #227

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I've presented you with this problem I have of constant "Channel mode is stale" 
warnings. I believe it wasn't a bug as such and it was put aside.

A solution for my error log filling up with this Warning that doesn't actually 
affect much is to change the logging level of it. 
It would be nice if it was moved down a notch or two so it isn't caught with 
all the "real" errors.

BR

Original issue reported on code.google.com by Tnade...@gmail.com on 15 Jan 2015 at 11:47

GoogleCodeExporter commented 9 years ago 
Thinking about it, I think the error was that it never requested a new mode so 
it was forever stale... Not 100% sure. 

The conv died off after you couldn't reproduce.

Original comment by Tnade...@gmail.com on 15 Jan 2015 at 11:51

GoogleCodeExporter commented 9 years ago 
As strange as it may seem, Revision a91984dec752 might of fixed it. Can you 
test this? 

If not I have the attached patch, putting it here since I don't want to lose 
the work

Original comment by Lord.Qua...@gmail.com on 24 Jan 2015 at 9:57

Attachments:

GoogleCodeExporter commented 9 years ago 
I'm running 20150124-100021-106. Joining a channel, getting OP. Quitting 
channel. Rejoining and quitting. Every quit regardless of auto OP or not 
produces channel is stale warning.

Original comment by Tnade...@gmail.com on 24 Jan 2015 at 11:43

GoogleCodeExporter commented 9 years ago 
Can reproduce on esper (Charybdis) and other network (Unreal3.2.9).

To clarify every quit after the steps produces the warning. If it matters I 
only parted from one of the channels the bot was in (on the same network) to 
reproduce this.

It happens on both part and quit afaik.

Original comment by Tnade...@gmail.com on 24 Jan 2015 at 11:49

GoogleCodeExporter commented 9 years ago 
Log: http://pastebin.com/WbfzMaxt

Original comment by Tnade...@gmail.com on 24 Jan 2015 at 12:06

GoogleCodeExporter commented 9 years ago 
http://pastebin.com/RRQA2R5g
Doesn't happen if the user doesn't have OP. If you manually OP the user the 
next quit will produce the warning and every quit after regardless of status.

Original comment by Tnade...@gmail.com on 24 Jan 2015 at 12:09

GoogleCodeExporter commented 9 years ago 
Fixed in Revision 1e8cf7df0847 and confirmed on IRC. yay!

Original comment by Lord.Qua...@gmail.com on 24 Jan 2015 at 8:03