raisedragon / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

IRC code 376 signifies a working IRC connection in some cases #53

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Install I2P, connect to the I2P IRC server.
2. You will never connect successfully, since no 004 message occurs. Instead, 
376 (end of MOTD) occurs.

This is not standardized as far as I know, but it does appear at least this one 
server implements this system.

Example:
1324929621802 <<<:irc.freshcoffee.i2p 376 i2pgate4 :End of /MOTD command.

Original issue reported on code.google.com by mathias....@gmail.com on 26 Dec 2011 at 8:12

GoogleCodeExporter commented 9 years ago
This should be fixed by replacing:
if (code.equals("004"))

by

if (code.equals("004") || code.equals("376"))

Original comment by mathias....@gmail.com on 26 Dec 2011 at 8:15

GoogleCodeExporter commented 9 years ago
That almost sounds like a bug in I2P. I'm pretty sure sending 004 is per the 
RFC somewhere as almost every other server does that. The mIRC code lookup even 
describes the code as "Sent to all clients once a connection has been 
established and the user has successfully registered". See here:

http://www.mirc.net/raws/?view=004

I will add support for this in PircBotX simply because it can be useful and the 
MOTD is always sent after 004. But there needs to be a bug report files with I2P

Original comment by Lord.Qua...@gmail.com on 26 Dec 2011 at 11:12

GoogleCodeExporter commented 9 years ago
Hmm, its not listed in RFC1459 but 004 is listed in RFC2812. You can also 
mention that pretty much all existing IRC servers send that code.

When looking around though, I'm not sure where to report it. I2P looks alot 
like tor, which means it only provides the networking, not the actual IRC 
server. Your connection line just looks like an off the shelf IRC server thats 
hooked into the I2P network. Is there a special I2P server that your using or 
can I just not find it?

Original comment by Lord.Qua...@gmail.com on 26 Dec 2011 at 11:24

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Sorry, I should have elaborated a bit.
I2P indeed specifies the network layer, not an IRC server.

However, this is an IRC server that runs on top of the I2P network layer. I'm 
afraid I don't know what IRC server it is exactly (I would expect it to be 
either 'off-the-shelf' or slightly modified), I'm not the operator. I will let 
the operator know (the server is irc.postman.i2p) and will see if I get any 
response.

I see code 376 mentioned here, by the way: http://www.faqs.org/rfcs/rfc1459.html

Original comment by mathias....@gmail.com on 27 Dec 2011 at 7:12

GoogleCodeExporter commented 9 years ago
The operator (known as 'postman') says his server is a regular server.

I've also tried different I2P configurations and I don't see a difference.

Original comment by mathias....@gmail.com on 24 Jan 2012 at 3:28

GoogleCodeExporter commented 9 years ago
Sorry for the delay, life and school have been taking up my time.

Fixed in Revision 21e588cd1f06

Original comment by Lord.Qua...@gmail.com on 26 Jan 2012 at 1:39