raisedragon / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

DeOpEvent, etc #61

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I noticed that DeOpEvent is missing, where onDeop had existed before. I know 
you could use ModeEvent, but doesn't it make sense to have a DeOp event? This 
would be a very nice feature to have.

Original issue reported on code.google.com by jkc.clem...@gmail.com on 24 Feb 2012 at 5:01

GoogleCodeExporter commented 9 years ago
I've actually condensed OpEvent and DeOpEvent a while ago. This was because of 
the new supported user modes it would get crazy really fast with a bunch of 
different event classes for adding and removing of a user mode. 

IE to listen for a DeOp, listen for OpEvent and check event.isOp()

I probably should of documented this in the PircBot differences page. 

Original comment by Lord.Qua...@gmail.com on 24 Feb 2012 at 5:32

GoogleCodeExporter commented 9 years ago
isOp and isVoice, etc. are deprecated. Mind changing those if you want devs to 
use them?

Original comment by jkc.clem...@gmail.com on 1 Mar 2012 at 11:18

GoogleCodeExporter commented 9 years ago
Excuse me, only isVoice is deprecated.

Original comment by jkc.clem...@gmail.com on 1 Mar 2012 at 11:19

GoogleCodeExporter commented 9 years ago
Sorry, meant hasVoice. Deprecated Javadoc for isVoice should of pointed you 
there: 
http://site.pircbotx.googlecode.com/hg-history/1.6/apidocs/org/pircbotx/hooks/ev
ents/VoiceEvent.html#isVoice%28%29 . Other methods like isOp are not 
deprecated: 
http://site.pircbotx.googlecode.com/hg-history/1.6/apidocs/org/pircbotx/hooks/ev
ents/OpEvent.html#isOp%28%29

---

I also went ahead and updated the wiki, should help others: 
https://code.google.com/p/pircbotx/wiki/DifferencesFromPircBot#Important_Changes

Original comment by Lord.Qua...@gmail.com on 1 Mar 2012 at 7:17

GoogleCodeExporter commented 9 years ago

Original comment by Lord.Qua...@gmail.com on 1 Mar 2012 at 7:17