raisedragon / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

Server side nick changes are not kept up to date #84

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The best example I can give of this is joining an irc bouncer such as ZNC.
If I connect to ZNC with a normal client, it will update to the nick currently 
used on ZNC. However joining ZNC as a server will cause PircBotX.getNick() to 
return "PircbotX" or whatever the default nick is.

This is also related to the fact that server side nick changes are not tracker 
by the bot.

If this were git and github I would spend some time creating a patch to fix 
this, but I haven't really looked into how the nick is specified on server 
connect. (Or how to submit patches with hg + google code)

Regards md_5

Ps: You should get on your irc channel sometime.

Original issue reported on code.google.com by the.md5e...@gmail.com on 13 Sep 2012 at 10:36

GoogleCodeExporter commented 9 years ago
Hehe:
https://github.com/md-5/pircbotx

Worked better than I expected.

Original comment by the.md5e...@gmail.com on 13 Sep 2012 at 10:42

GoogleCodeExporter commented 9 years ago
Google has a source clone feature at 
https://code.google.com/p/pircbotx/source/clones so that you can clone the 
project into your own account. You can also submit patches through the issue 
system, which honestly is enough most of the time unless you want to submit a 
lot of patches at once for some reason.

I'll take a look though

Original comment by Lord.Qua...@gmail.com on 13 Sep 2012 at 12:02

GoogleCodeExporter commented 9 years ago
This seems to be a ZNC issue. In Windows I had some trouble because it didn't 
send the nick change line. In Linux (Fedora 17) though it seems to be working 
with a mostly default install of ZNC. 

I'm going to close this as Invalid since its not PircBotX

Original comment by Lord.Qua...@gmail.com on 19 Oct 2012 at 5:33

GoogleCodeExporter commented 9 years ago
That seems really odd. When I ran the bot with verbose on, ZNC was indeed 
sending the NICK lines just as a normal ircd does, however pircbotx was still 
ignoring them.

I don't think anything has changed to make this not the case.

Original comment by the.md5e...@gmail.com on 20 Oct 2012 at 10:18

GoogleCodeExporter commented 9 years ago
Sorry, not ignoring your comment, just have little free time nowadays. 

Attached is the raw logs of both the ZNC server and PircBotX in Windows 7. I'm 
using ZNC 0.202r2-Win-x64 - http://znc.in. 

As you can see there is no nick line sent. The Linux build on the other hand 
sends the nick line and PircBotX is able to change its own nick.

Original comment by Lord.Qua...@gmail.com on 23 Oct 2012 at 2:26

Attachments:

GoogleCodeExporter commented 9 years ago
I'll have to test myself, because I use the linux version and my raw logs did 
indeed reveal a nick line sent, but then inspecting bot.getNick() returned 
"Pircbotx" even though that nick was never used.

Original comment by the.md5e...@gmail.com on 24 Oct 2012 at 4:48