raisedragon / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

Couple of small things -> Convenience methods, lombok sync #87

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
https://code.google.com/r/themd5encryption-pircbotx/source/list

Would like the first two commits to be looked at if possible.

Thanks

Original issue reported on code.google.com by the.md5e...@gmail.com on 15 Sep 2012 at 4:37

GoogleCodeExporter commented 9 years ago
Revision fffde17f1d8c (the first one) I don't think I'm going to add. 
ManyToManyMap was really conceived as a general purpose map that I could say 
"Hey, if your looking for a Many to Many map, here's an implementation that you 
can use". Adding lombok, while it does look cleaner, hinders your ability to do 
something like that. 

The PircBotX part of that commit also probably wouldn't work, as I was only 
wanting to synchronize on what was necessary, the userNickMap doesn't require 
synchronization

Revision fffde17f1d8c definitely will be added and it baffles me that I never 
thought of a sendMessage method in those classes before. I'll add it very soon

Original comment by Lord.Qua...@gmail.com on 15 Sep 2012 at 5:00

GoogleCodeExporter commented 9 years ago
Added as  Revision 36f618a2ca20

Original comment by Lord.Qua...@gmail.com on 15 Sep 2012 at 8:15