search

raisedragon / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

Implement an event when a socket level connection is made. #97

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I personally feel the onConnected event is misnamed, and should be named to 
onRegistered, and onConnected be moved to just after the socket connection is 
attempted. While realistically speaking this would be a breaking change, I 
propose a onSocketConnect event to be dispatched right after connection 
attempts. This would allow for pre-registration stuff, such as SASL and CAP 
functionality.

Original issue reported on code.google.com by entityreborn on 21 Dec 2012 at 12:24

GoogleCodeExporter commented 9 years ago 
Sorry, I guess this should be a feature, I didn't see where to change the type 
for this issue.

Original comment by entityreborn on 21 Dec 2012 at 12:25

GoogleCodeExporter commented 9 years ago 
This patch supports the requested functionality, adding SocketConnectEvent, 
tests, and listener hook.

Original comment by entityreborn on 21 Dec 2012 at 2:11

Attachments:

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
An example implementation: https://gist.github.com/4356024
Adds SASL auth.

Original comment by entityreborn on 21 Dec 2012 at 9:41

GoogleCodeExporter commented 9 years ago 
Added in Revision ec6f111174bd. Thank you so much for the patch!

Small note: I try to keep the issue number in the commit message as it makes it 
easier to update the changelog and to track the commit if you go spelunking 
through the repo history

Original comment by Lord.Qua...@gmail.com on 24 Dec 2012 at 5:33