search

raisimTech / raisimLib

Visit www.raisim.com
http://www.raisim.com
Other
341 stars 91 forks source link

python now installs to site-packages #465

Closed jhwangbo closed 1 year ago

wxmerkt commented 1 year ago

Hi @jhwangbo, this change may break installations and use cases, particularly through: (i) non-venv python installations on Ubuntu - both through the switch away from the platform-specific slug as well as by replacing ${PYTHON_EXECUTABLE} with python which wont work on stock Ubuntu for instance (ii) no longer installs the library assets as e.g. used in workspaces

Would it be possible to revert some of these changes? Or understand which use cases were broken by the previous logic?

jhwangbo commented 1 year ago

Thank you for pointing them out. Before I revert some of the changes, can you tell me what this line from your commit supposed to do print(sc.get_python_lib(prefix='', plat_specific=True))? This was the key change in my commit

wxmerkt commented 1 year ago

I commented on the older PR - it is meant to extract the correct installation path and slug based on the setup e.g. whether it's a native distro or venv and whether to use full python3.x or python3 paths.

Unfortunately, this PR seems to also have reverted the lib installation and CMake config files: image