search

raissonsouto / pijama2json

A script that scraps data about UFCG courses offered from a PDF and turns into JSON.
1 stars 2 forks source link

added parse_schedule function and enhancements to the extract_course_… #7

Closed PedramHaeri closed 11 months ago

PedramHaeri commented 11 months ago

…details function for improved error handling and schedule parsing.

raissonsouto commented 11 months ago

Hey @PedramHaeri, I'm very happy in receiving your PR. The concept behind the issue you ask to be signed involves breaking down scrape_data() into smaller functions, is well executed with the creation of parse_schedule(). However, it appears that there are some missing functions, such as a function to get the professor (or professors) name, obtaining the class name, retrieving the vancancies and fetching class id.

Also, remove the comment lines (if the comment is really needed, it should be in the docstring) and the comment function as well.

PedramHaeri commented 11 months ago

Thanks for your feedback. I just added the necessary functions based on the original one and cleaned up the comments. Please let me know if you have any more questions

raissonsouto commented 11 months ago

I checked out the new code version and I'm glad you made some great improvements based on my feedback. But here's the thing: even though you created those suggested functions, you haven't used them anywhere in the code. So, why aren't you calling them?

PedramHaeri commented 11 months ago

Oops silly me. I forgot to add the updated function. Give me a minute and I'll get it updated

raissonsouto commented 11 months ago

thanks for your contribution :rocket: