raithos / xwing

Squad builder for the X-Wing Miniatures game by Fantasy Flight Games.
https://raithos.github.io/
MIT License
59 stars 77 forks source link

Your Collection Idea #1353

Closed matthewlauletta closed 6 months ago

matthewlauletta commented 6 months ago

Is your feature request related to a problem? Please describe. When adding cards to "Your Collection" it is difficult when multiple cards have the same name.

Describe the solution you'd like It would be great to add the card type icon and more descriptive in parenthesis.

For example; Astromech symbol R2-D2 (Rebel) Astromech symbol R2-D2 (Republic)

Or

Pilot Symbol Chewbacca Crew Symbol Chewbacca

Additional context Add any other context or screenshots about the feature request here.

Here is a screenshot of this issue. How do I know which Ahsoka Tano card I have because there is no differentiation.

Screenshot 2024-01-10 at 15 01 36
matthewlauletta commented 6 months ago

I'm sorry, This is only the case in the Pilot section. I want to make sure I am adding the correct pilot card.

Thank you

Patschke commented 6 months ago

Hmm. What's easy to fix is adding all those missing icons:

image

Often this is already enough to tell which one is which, e.g. it's clear which of the many Ezras one wants to select:

image

I don't have a good idea on how to differentiate between multiple pilots on the same ship (or almost the same ship, like it is here the case for Delta-7 vs Delta-7b). We could of course add the full ship name in parenthesis, but this won't be enough for all cards, e.g. Dash Rendar. They have of course unique identifier (aka XWS codes), but that's not really human-readable...

matthewlauletta commented 6 months ago

Ok. I understand the issue. I have a few ideas.

  1. On hover, show the card text.
  2. Maybe part of the fix would be stating which edition it is from. I think that is the issue with Dash Rendar.
  3. Link to a wiki that has the image of the card.

I want you to know that I really appreciate YASB and thank you for doing what you do.

raithos commented 6 months ago

This fix will have to wait until after Feb as I have a number of unpushed changes due to the battle over endor stuff. Sorry!

raithos commented 6 months ago

never mind, i had to fix the facebook thing so i stashed all my changes for now, this is resolved via @Patschke's fix. I am issuing a seperate fix for dash, I am renaming the scum one to not be confused with the rebel one.

Patschke commented 5 months ago

There are no different icons for Delta 7 and Delta 7b. Also, only half of them really exist, while the other one is only available as print out. I guess for tournaments, the Delta 7 card is the one technically required for both options? So I am somewhat fine with leaving that as is?

raithos commented 5 months ago

yeah for delta 7b you cant buy it in product so you just have it, so people can do whatever they want there. So there's basically 1 edge case that the existing solution doesn't solve, and it's not enough for me to do anything about it, you need the same pilot, and same ship, different factions. pilots in the same ship and same faction are differentiated anyway so none of that is a problem, and different ships are already taken care of. there's exactly 1 case that i am aware of there and its durge and both pilots come in the same pack so i dont care.