raithos / xwing

Squad builder for the X-Wing Miniatures game by Fantasy Flight Games.
https://raithos.github.io/
MIT License
60 stars 81 forks source link

Dash Rendar R2D7 #1394

Closed BuddyHG closed 3 months ago

BuddyHG commented 3 months ago

Describe the bug When posting YASB links in Discord, Dash Rendar does not post. I know nothing about tech and unsure if this is a YASB thing or a R2D7 thing, but Dash works when posted from LBN.

To Reproduce Steps to reproduce the behavior:

  1. Create a Rebel list that includes Dash Rendar
  2. Post the link in a Discord server that uses the R2D7 feature

Screenshots Screenshot 2024-06-13 211046

Patschke commented 3 months ago

Not sure who's correct there. We currently output the four different Dash Rendars as dashrendar, dashrendar-swz103, dashrendar-swz103-sl-rebelalliance and dashrendar-swz103-sl-scumandvillainy. Given that there is no other non standard-loadout version of Dash in swz103 (scum does have just one version), our naming scheme seems unambigous to me? However, as LBN, R2D7 and (perhaps most importantly?) xwing-data2 all agree that it should be dashrendar-swz103-rebelalliance, we should adapt accordingly.

The same is true for Leebo.

Thanks for the note