Available for completing italian translation

piffopi commented 3 years ago

YASB 2.0 Bug Report

I'm available to complete the translation to italian (former product line translator and reviewer here)

Expected Behavior

should be translated

Actual Behavior

missing translations

Language

italian

raithos commented 3 years ago

go do it! cards-it.coffee is the file to edit under the content/translations directory

piffopi commented 3 years ago

Cheers, fantastic. I forked it, i'll send a pull whenever i can :) gonna take some time though, the translation was stopped with the end of localization. (EDIT: this was after Wave 3. So e.g. Vulture Droids are in italian, Nantexes and so on are not!) Just one question (i'm not really an expert) is there a way to figure out which cards have been added to the database, but not translated? So i can filter them out, translate them , add them back and sort the file.

piffopi commented 3 years ago

Two more questions: 1)in what file I can edit the highlighted assets? I'd start from that

2) What does CHANGE ME CHANGE ME stand for? is it a note to self?

Patschke commented 3 years ago

1) Have a look at the german translation file to find the places for those translations. No proper system for that has been set up (yet), so not all UI elements might be open for tranlsation.

2) There has been an automated script to crawl the translations FFG provided. That script would automatically create the cards-it.coffee file. Those CHANGE ME are place holder for stuff like faction names or phrases ("... only") that this script added automatically. Their origin was the phrase-translation file As I've never found anyone who bothered to translate those phrases, "CHANGE ME" ended up in the actual card texts. A long time ago I hoped that somebody would notice and provide translations... Unfortunately FFG closed their API, so it is no longer possible to automatically generate the cards-xy.coffee files. So even if you translate the phrases now I am not sure if it is possible to create the italian language file from it again... Of course, if one finds a new way to grab the translations from FFG (AMG) that would be a better solution than crunshing in all data from the new waves manually...

piffopi commented 3 years ago

Have a look at the german translation file to find the places for those translations. No proper system for that has been set up (yet), so not all UI elements might be open for tranlsation.

There has been an automated script to crawl the translations FFG provided. That script would automatically create the cards-it.coffee file. Those CHANGE ME are place holder for stuff like faction names or phrases ("... only") that this script added automatically. Their origin was the phrase-translation file As I've never found anyone who bothered to translate those phrases, "CHANGE ME" ended up in the actual card texts. A long time ago I hoped that somebody would notice and provide translations... Unfortunately FFG closed their API, so it is no longer possible to automatically generate the cards-xy.coffee files. So even if you translate the phrases now I am not sure if it is possible to create the italian language file from it again... Of course, if one finds a new way to grab the translations from FFG (AMG) that would be a better solution than crunshing in all data from the new waves manually...

Thanks, i have used the german file as template. It's easier to do that. Since the minority of italian cards was translated, i'm rehauling the whole thing. That allows me to also add some fixes that were unforeseen when the Conversion Kits were translated. Working on my own fork, hopefully there won't be issues with the main project (again, not a github/coding expert here). The italian file will definitely need a review before pulling!

Patschke commented 3 years ago

Regarding UI translation:

I've done a rework of the translation system, to allow for proper UI translation. All the stuff you marked yellow in the picture above is now somewhat proper translateable. As soon as it's live you can open a console in your browser (Ctrl+Shift+K in Firefox, Ctrl+Shift+J in Chrome) and set SHOW_DEBUG_OUT_MISSING_TRANSLATIONS = true;. This will display all missing translation the system encounters, so you will find all UI elements by changeing from italian to english and back. I've also tried to complete the german translation file, so it can serve as template if you prefere that.

The card translation system has been unchanged.

Patschke commented 3 years ago

Are you still interested in updating the italian translation? I see that there are no commits to your fork since May 4th - if this was a star-wars-day-project you lost interest in after that day, I'd like to know if there has been done enough that it is worth to merge the changes? Or are you are still working on that (perhaps just offline)? If the answere to both questions is no we can close this issue.

Don't get me wrong: I am always happy if somebody contributes in updating languages - and am willing to help you with that if you have any questions on how to proceed. I just don't want stale open issues to clutter this repository.

piffopi commented 3 years ago

Hi, yes, still interested

Last month was a nightmare between finalizing the organization of XTC (Piffo here :D ), a sudden work spike and my dad catching covid that literally hindered EVERY SINGLE free hour I had, forcing me to drive up and down 200km every day. Anyways, I plan to work on it in the forthcoming weeks.

Sorry for the thread open, but regular work (architect) + teaching uni sometimes leads to unforeseen workload

Cheers

F

On Sun, 13 Jun 2021, 12:18 Patrick Mischke, @.***> wrote:

Are you still interested in updating the italian translation? I see that there are no commits to your fork since May 4th - if this was a star-wars-day-project you lost interest in after that day, I'd like to know if there has been done enough that it is worth to merge the changes? Or are you are still working on that (perhaps just offline)? If the answere to both questions is no we can close this issue.

Don't get me wrong: I am always happy if somebody contributes in updating languages - and am willing to help you with that if you have any questions on how to proceed. I just don't want stale open issues to clutter this repository.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/raithos/xwing/issues/779#issuecomment-860187071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGYFTVJRTHVNFBTXT7QGJDTSSAXVANCNFSM44A5AULA .

piffopi commented 3 years ago

Btw, ABSOLUTELY no offence taken! specifying, just in case

I absolutely see your point :)

On Sun, 13 Jun 2021, 12:18 Patrick Mischke, @.***> wrote:

Are you still interested in updating the italian translation? I see that there are no commits to your fork since May 4th - if this was a star-wars-day-project you lost interest in after that day, I'd like to know if there has been done enough that it is worth to merge the changes? Or are you are still working on that (perhaps just offline)? If the answere to both questions is no we can close this issue.

Don't get me wrong: I am always happy if somebody contributes in updating languages - and am willing to help you with that if you have any questions on how to proceed. I just don't want stale open issues to clutter this repository.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/raithos/xwing/issues/779#issuecomment-860187071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGYFTVJRTHVNFBTXT7QGJDTSSAXVANCNFSM44A5AULA .

Patschke commented 3 years ago

Don't worry, and take your time. If need be I'll be as patiently waiting for the translation as I am waiting for in person X-Wing events - I personally do not enjoy X-Wing via TTS, so my last tournament is loooong ago ;-) I wish your dad a speedy and full recovery.

piffopi commented 3 years ago

Thanks for understanding! Hopefully dad will be "out of it" soon, he had his first "control" swab this morning.

Filippo Bosi https://linktr.ee/piffo

Il giorno mar 15 giu 2021 alle ore 12:49 Patrick Mischke < @.***> ha scritto:

Don't worry, and take your time. If need be I'll be as patiently waiting for the translation as I am waiting for in person X-Wing events - I personally do not enjoy X-Wing via TTS, so my last tournament is loooong ago ;-) I wish your dad a speedy and full recovery.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/raithos/xwing/issues/779#issuecomment-861396512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGYFTTXYFRRB2IOMQOYDCLTS4V4LANCNFSM44A5AULA .

raithos commented 3 years ago

any update on this?

piffopi commented 3 years ago

Hey, I'm still swamped between work and XTC - but I should start having more time to work on it from Wednesday :)

Apologies for the massive delay, my dad catching covid did not help at all. I had to drive 400km back and forth most days for 1 month

Piffo

On Tue, 29 Jun 2021, 08:30 raith, @.***> wrote:

any update on this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/raithos/xwing/issues/779#issuecomment-870277404, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGYFTS5ALAKCXRBSX4AX53TVFR7XANCNFSM44A5AULA .

raithos commented 3 years ago

ping about if there is an update

piffopi commented 3 years ago

Finally re-starting the job! I'm using the german file as template, for an easier process.

piffopi commented 3 years ago

UI and all names translated - btw i'm working locally with Notepad++, this is why you don't see updates on the fork. next step is dealing with card abilites. this might take a bit more time, as i also have to double check the errata and deal with formatting.

keep you posted.

Patschke commented 2 years ago

Sorry for mentioning this with 9 day delay, but: The ability translation can be automated. I can do that, so no need for you to manually translate all card abilities. There will still be something that needs to be done manually: Checking the errata (and manually adding an errated card text together with a note that and how and since when the card has been changed) and adding the device/condition translations. Also some clean-up might be required for any double-sided cards.

I'll try to generate an up-to-date card ability translation later today.