search

raitonoberu / sptlrx

Synchronized lyrics in your terminal
MIT License
385 stars 18 forks source link

Don't require root for installation #3

Closed jottr closed 2 years ago

jottr commented 2 years ago

Please refrain from using $ curl -sSL instl.sh/raitonoberu/sptlrx/macos | sudo bash. This is considered bad practice and deemed unsafe.

Why does your script require root in the first place?

raitonoberu commented 2 years ago

I use instl to provide an automatic installation. This requires root because it puts the executable file in /usr/local/bin.

I am aware of the fact that this is a bad practice, so the user has the option to download it and install it manually. This will be removed from the README as soon as the package is available in the main repositories (already in AUR).

HadetTheUndying commented 2 years ago

Placing the file in ~/.local/bin is probably a better idea and then recommending users add that to their $PATH. Your README.md doesn't have any build instructions so most people will default to just using curl to pull the prebuilt binary, better safe than sorry.