search

raitonoberu / sptlrx

Synchronized lyrics in your terminal
MIT License
354 stars 14 forks source link

DRAFT: Multi-player, Multi-lyric source enhancements (IN PROGRESS) #40

Open BrianCArnold opened 5 months ago

BrianCArnold commented 5 months ago

I'm not a Go developer, so I'm still working on how to do what I want to do, but generally the idea is to list multiple players in the configuration and multiple lyric source configurations, so that if the hosted or Spotify lyric sources don't provide lyrics, but the user has .lrc files present, it will use those as a backup.

Also, looking into changing how the query data is passed to the lyrics providers, so that we can check the local file sources to make sure that the album, artist, and song title are present, and also if the path of the local MPRIS player specifies a specific file path, check that file path for a matching .lrc file.

If any Go developers have ideas on how to make it listen to multiple players, please let me know, I'm a C# guy.

sanderr commented 1 month ago

Looking forward to this. I especially love the part "if the path of the local MPRIS player specifies a specific file path, check that file path for a matching .lrc file." The current local provider is a bit too naive for my library, and this should solve a large part of that. I was considering to create a PR for that myself when I discovered this one.