search

raiyanyahya / dallecli

💠 Provide users with the ability to generate, edit and filter images using the DALL-E 3 API provided by OpenAI, all from the command line.
https://dallecli.com
MIT License
60 stars 8 forks source link

When calling with --iterations parameter images are not copied/moved to save path #56

Open carnager opened 8 months ago

carnager commented 8 months ago

When i run dallecli generation --iterations 4, dallecli creates 4 temporary files in /tmp, but never moves them to ./images (or the path defined with --save-path)

Expected Behavior

I expect dallecli to respect save path when creating more than one image.

raiyanyahya commented 8 months ago

Is this only happening when you use iterations ? Is it saving files correctly when using 0 iterations ? OpenAI's new dalle 3 api which is now a default only allows 1 request at a time. I wonder if that is causing a problem. I will check. Thank you!

carnager commented 8 months ago 
/home/carnager/.local/bin/dallecli generate --iterations 0 --save-path "/home/carnager/Pictures/blub.png" --prompt "bear reading multiple books"

creates nothing, which is somewhat expected? also, shouldn't --save-path define a directory instead of a filename, when using it with itereations parameter? Otherwise each iteration would overwrite the former.

I guess to make things consistent there should be 2 options, one for save-directory and one for filename. filename should probably add some kind of unique id to each generation, so there is no name clashes.