search

rajadilipkolli / mfscreener

Spring Boot REST API which fetches the Net Asset Value(NAV) of an AMFI mutual fund and saves in db
https://rajadilipkolli.gitbook.io/mutualfunds-screener/
3 stars 0 forks source link

fix : reduce cognitive complexity #334

Closed rajadilipkolli closed 7 months ago

rajadilipkolli commented 7 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 7 months ago

Walkthrough

The updates in the services HistoricalNavService and UserSchemeDetailsService enhance data retrieval, processing, and error handling. HistoricalNavService now constructs URIs, fetches and processes data efficiently, and persists scheme information. UserSchemeDetailsService provides clearer log messages during historical data loading. Additionally, a new test method in NavControllerIT.java tests loading data when a scheme is not found and historical data is loaded.

Changes

File Path Change Summary
.../service/HistoricalNavService.java
.../service/UserSchemeDetailsService.java		 Enhanced URI construction, data fetching, processing, error handling, and scheme information persistence. Updated log message for historical data loading in UserSchemeDetailsService.
.../test/java/com/learning/mfscreener/web/controllers/NavControllerIT.java Added a new test method to load data when a scheme is not found and historical data is loaded.

🐰✨ In the realm of code, where logic is king, Two services danced, and changes they bring. One fetches data with a meticulous flair, Another groups folios with utmost care. Here's to the devs, with their craft so bright, Coding through day, reviewing by night! 🌟

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 4bd6312338a25eca8bc918d665eaec1aa537194a and 7b4b3428cffe4fcfef1564fe15082f2e529077a4.
Files selected for processing (2) * src/main/java/com/learning/mfscreener/service/HistoricalNavService.java (1 hunks) * src/test/java/com/learning/mfscreener/web/controllers/NavControllerIT.java (2 hunks)
Files skipped from review as they are similar to previous changes (2) * src/main/java/com/learning/mfscreener/service/HistoricalNavService.java * src/test/java/com/learning/mfscreener/web/controllers/NavControllerIT.java
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.