search

rajadilipkolli / mfscreener

Spring Boot REST API which fetches the Net Asset Value(NAV) of an AMFI mutual fund and saves in db
https://rajadilipkolli.gitbook.io/mutualfunds-screener/
3 stars 0 forks source link

fix : quicken up loading 31stJan2018 NAV #350

Closed rajadilipkolli closed 6 months ago

rajadilipkolli commented 6 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

The changes encompass a transition to MFSchemeNavService from HistoricalNavService for handling NAV data, enhancing date parsing in DTO-to-entity mapping, and restructuring repositories. Notable updates include the introduction of a new repository interface, method optimizations, and code clarity improvements across services.

Changes

File Path Change Summary
.../config/Initializer.java Updated imports and method parameters to use MFSchemeNavService.
.../mapper/MfSchemeDtoToEntityMapper.java Enhanced date parsing in the updateMFScheme method.
.../repository/MFSchemeNavEntityRepository.java Added a repository interface for counting entities by date.
.../repository/MFSchemeRepository.java Removed a specific count method.
.../service/HistoricalNavService.java Extensive refactoring, method removal, and code optimization.
.../service/MFSchemeNavService.java Introduced methods for loading and verifying NAV data.
.../service/SchemeService.java Added dependencies and a method to load data for closed or merged schemes.

Poem

🌟 Oh hark! A code reforged anew, 🌟
Where old paths fade and fresh winds blew.
A rabbit danced on digit's green,
Through lines of code, a sight unseen.
With every hop, a bug's defeat,
In binary meadows, change is sweet. 🐇💻

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between e17daf0618aea5ae27536fdb04faf45b47f17546 and 1fd8a151e756ad1093e80c9e1b444731e8e174e2.
Files selected for processing (2) * gradle.properties (1 hunks) * src/test/java/com/learning/mfscreener/web/controllers/PortfolioControllerIT.java (9 hunks)
Files skipped from review due to trivial changes (1) * gradle.properties
Additional comments not posted (7)
src/test/java/com/learning/mfscreener/web/controllers/PortfolioControllerIT.java (7)
`34-36`: Use of try-with-resources for `FileWriter` ensures proper resource management and is a good practice. --- `63-65`: Proper use of try-with-resources for `FileWriter` in this context is noted and approved. --- `91-93`: Consistent use of try-with-resources for `FileWriter` enhances resource management. --- `119-121`: Good practice of using try-with-resources for `FileWriter` is maintained across methods. --- `148-150`: Continued good practice with try-with-resources for `FileWriter` in this test method. --- `175-177`: Effective use of try-with-resources for `FileWriter` ensures clean resource handling. --- `200-204`: Renaming the method to `addMultipleSchemesAndTransactions` clarifies its functionality. Consistent use of try-with-resources for `FileWriter` is noted.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
rajadilipkolli commented 6 months ago

@coderabbitai review