search

rajanadar / VaultSharp

A comprehensive cross-platform .NET Library for HashiCorp's Vault, a secret management tool
http://rajanadar.github.io/VaultSharp
Apache License 2.0
493 stars 134 forks source link

Support for ldap secret engine, static and dynamic roles #333

Closed protonyx closed 2 months ago

protonyx commented 12 months ago

Fixes a type mismatch bug with the existing LDAP secret engine implementation. Adds full support for static and dynamic roles in the LDAP secret engine.

Vault API Docs: https://developer.hashicorp.com/vault/api-docs/v1.13.x/secret/ldap

protonyx commented 11 months ago

I agree with all suggestions, though I was following the conventions in the database secret engine so it might be worth revisiting as well.

I also noticed that the LDAP secret engine is referenced as OpenLDAP in the code, which no longer aligns with the Hashicorp documentation. Should that be modified as well?

konidev20 commented 11 months ago

I also noticed that the LDAP secret engine is referenced as OpenLDAP in the code, which no longer aligns with the Hashicorp documentation. Should that be modified as well?

Hey, I guess we must not, since it would affect backward compatibility. We need to check with @rajanadar on this. The process is to mark it as a breaking change, but I'm not sure whether it will go in a patch or a major release.

protonyx commented 11 months ago

Any additional feedback for this PR?