search

rajanadar / VaultSharp

A comprehensive cross-platform .NET Library for HashiCorp's Vault, a secret management tool
http://rajanadar.github.io/VaultSharp
Apache License 2.0
488 stars 130 forks source link

feat: allow sending generic API requests #352

Closed MaximBalaganskiy closed 1 week ago

MaximBalaganskiy commented 4 months ago

This will allow for calling APIs which are missing in the current implementation

Zetanova commented 2 months ago

would resolve https://github.com/rajanadar/VaultSharp/issues/342

rajanadar commented 1 week ago

this is a fantastic intent @MaximBalaganskiy . I 100% understand what this is meant to do.

However, the sole purpose of VaultSharp is to be that strong first-class C# layer to hide all http/api things.

It is also the motivation for users to raise missing api features and for us to add it as strongly typed methods.

Doing this will open up the http world to callers, who will then have this weird hybrid code in production and management rarely gives time to unwind those things.

I am going to close this PR solely due to the core tenet of the library. Not to expose polymath/http at all. Your intent is 100% appreciated.