Closed bjorn-einar-bjartnes-4ss closed 11 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
ng7-dynamic-breadcrumb | ❌ Failed (Inspect) | Aug 1, 2023 8:49am |
There are still some issues remaining upgrading it
Some type issues after upgrading
Converted to draft, this was harder that expected.
@bjorn-einar-bjartnes-4ss Thanks for the PR contribution, Will check and publish on Weekend!.
@rajaramtt unfortunately I wasn't able to make it work, so it is not much of a contribution... ng14 to ng16 was harder than expected. Btw, haven't given up, but taking some time to learn more about this upgrade, there are more issues than with the upgrade from 12 to 14 in my experience so far.
This library is awesome. It's even better when the update to angular 16 can run. Please do it. Thank you.
Fairly sure this is not the way to upgrade, will try a new PR with using ng update properly and check in steps. Opened here https://github.com/rajaramtt/ng7-dynamic-breadcrumb/pull/51
Combined the changes I did when upgrading to v14 with the fixes you later did https://github.com/rajaramtt/ng7-dynamic-breadcrumb/commit/189191ef0318ebd6875b6880eb0604eff4496a62
https://github.com/rajaramtt/ng7-dynamic-breadcrumb/commit/4b60fd793cdd33ceb495ad5cd7064e2c9a1207c1
Skipped the v9 number in case someone would like to add support for angular 15 in between?