rajasegar / alacritty-themes

:rainbow: :lollipop: Themes :candy: :heart_eyes: for Alacritty: A cross-platform GPU-accelerated Terminal emulator
MIT License
685 stars 70 forks source link

is the master branch protected to doesn't push to it? #222

Closed JuanVqz closed 1 month ago

JuanVqz commented 1 year ago

Describe the bug

It seems the publishing workflow has been failing because there is a rule that requires at least 1 approving review.

stderr: 'remote: error: GH006: Protected branch update failed for refs/heads/master.        \n' +
    'remote: error: At least 1 approving review is required by reviewers with write access.        \n' +
    'To [https://github.com/rajasegar/alacritty-themes\n](https://github.com/rajasegar/alacritty-themes/n)' +
    ' ! [remote rejected] HEAD -> master (protected branch hook declined)\n' +
    "error: failed to push some refs to 'https://github.com/rajasegar/alacritty-themes'",

To Reproduce

Merge a PR into the master branch

Possible test case

Could you please deactivate the require at least 1 approving review feature, then merge a PR and see if it works?

Expected behavior

The publishing workflow should work

JuanVqz commented 1 year ago

@rajasegar, just wanted to mention that recently reached the same issue, and dug a little bit.

Found this: Only the auth-only level of npm two-factor authentication is supported, semantic-release will not work with the default auth-and-writes level.

That should be changed in your npm account to make it works back.

Reference:

rajasegar commented 1 year ago

@JuanVqz I have enabled 2FA for my npm account, can you please check and confirm?

JuanVqz commented 1 year ago

Yeah, having enabled the 2FA it's okay (I have it enabled too). Unfortunately, the semantic release package doesn't support auth and writes tokens you should generate a new token called only-auth to make it works again.