Add support for TOML - Githubissues

danilo-alm commented 5 months ago

Addressing issues #260 and #261

Some important considerations you might want to address:

Alacritty supports TOML file inclusion, so I'm including the file theme instead of copying its contents to the alacritty config;
Unused keys now trigger a warning prompting for user action, thus I left every theme's "name" and "author" keys commented out, since leaving them as keys would trigger the annoying warning;
The previous point implied that we cannot simply read the theme's "name" key to get its name, so I used their filenames;
A few themes' specific keys were not recognized by Alacritty; I commented them out (commit be3902c);
Tests were already broken, so I didn't bother fixing them for TOML. I tested the options available in --help manually and everything seemed okay.

danilo-alm commented 5 months ago

The themes were converted to TOML using the script yml_to_toml.py, 9e1b7c3.

danilo-alm commented 5 months ago

May be a problem to some people: I just noticed this approach wipes all comments. There's a discussion about comment-preserving parsers here and it seems that there aren't many, especially in javascript. It'd be a good to put a warning in the README.

rajasegar commented 5 months ago

@danilo-alm Thanks for pitching in for the TOML support What do you mean by tests are already broken? Do you think you can fix it, that would be greatly appreciated

danilo-alm commented 5 months ago

After checking out to master and running the tests on my computer, 3 of them fail; maybe I'm doing something wrong? I'm not going to look into fixing the tests, at least not now. Feel free to help, anyone!

I'm not very familiar with js, so just to make it clear, they fail after:

npm install --include=dev
npm test

rajasegar commented 2 months ago

@danilo-alm Thanks a lot for the PR, the changes are merged and a new release is cut

rajasegar / alacritty-themes

Add support for TOML #262