Closed JuanVqz closed 3 years ago
Once we have the standard theme's name we can add it to the name on each file content.
My thoughs:
@JuanVqz I really appreciate the work you are doing here by bringing in a lot of value to the codebase. We also need to have our vision and goals focused to the core capabilities of the program in alignment with the principle Do one thing and do it well
You are right! You can close this PR.
I understand that we should focus on do one thing and do it well but sincerely I’d like to see an order in the theme’s names I feel like it is a mess. Some of themes with slashes, another one with spaces, etc.
I suggest all in lower case but we can use Ayu Mirage
(with first letter per word on uppercase), or Aye-Dark
whenever you like but have a standard way to name it.
We can list the theme's name as uppercase changing it before showing the list.
I don't see any slashes in names, but yeah spaces and inconsistencies are there, I like this one Aye-Dark
@rajasegar we have some files with this format Baskerville-Ivory-Dark.yml
and others with this other format Atelierseaside.dark.yml
do we need to define a convention here? we may use Dark
in its name like the first one, which one do you like?
if it's ok like right now it is, you can review it, thank you.
@rajasegar Hello!
I did this way thinking in the "parameterize" the theme's name.
now, I have some questions.
what about if we may want to search by only light themes?
what do you think to add ".light.yml" to all files which don't have ".dark.yml"?
I got a fun time doing this with a node.js script (I didn't pushed because we don't needed it anymore)