search

rajasegar / alacritty-themes

:rainbow: :lollipop: Themes :candy: :heart_eyes: for Alacritty: A cross-platform GPU-accelerated Terminal emulator
MIT License
699 stars 71 forks source link

Improve create Alacritty config file method #37

Closed JuanVqz closed 3 years ago

JuanVqz commented 3 years ago

Refactoring createConfigFile method.

JuanVqz commented 3 years ago

Hi! @rajasegar, I'm using node 14 the tests passed in my local, it seems like a problem on node 16 with the promises or with a readFile because we are not closing the connection but I'm not sure.

I'll change the code by baby steps in order to see if I can solve it.

JuanVqz commented 3 years ago

even been in the master branch the tests suit fail when I'm using node v16.9.1, the weird thing it's the CI is not reporting the same.

Well, I am still on research and I switched to node v16.0.0, and master passed on my local env.

alacritty_themes

JuanVqz commented 3 years ago

I'll split this change