search

rajasegar / alacritty-themes

:rainbow: :lollipop: Themes :candy: :heart_eyes: for Alacritty: A cross-platform GPU-accelerated Terminal emulator
MIT License
696 stars 71 forks source link

Gracefully handle Ctrl-c and Escape #49

Open ineu opened 2 years ago

ineu commented 2 years ago

First of all I'd like to thank for the convenient tool to pick themes. There are some issues I've discovered: 1: The app incorrectly handles Ctrl-c:

  1. Run alacritty-themes
  2. Move to the next theme and quickly press Ctrl-c If the interrupt sequence is pressed fast enough, it catches the app in the middle of writing to alacritty.yml, leaving it half-written. The result is the broken config: изображение

The app should trap C-c and finish the cleanup first

2: The app incorrectly handles Esc:

  1. Run alacritty-themes
  2. Move to a theme
  3. Press Esc Expected: the selection process aborts, leaving the previous theme Actual: a theme under cursor is applied like if Enter was pressed.
JuanVqz commented 2 years ago

@rajasegar what do you think about adding a hacktoberfest label? it could help many people know about alacritty-themes.

rajasegar commented 2 years ago

Sounds good to me

rajasegar commented 2 years ago

@JuanVqz Added the label to the repo as well

JuanVqz commented 2 years ago

you already did it, thank you, what else can we add with the hacktoberfest label? BTW I'm about to add a contributors section in the readme, are you agree?

rajasegar commented 2 years ago

Yes :+1: