search

rajasegar / alacritty-themes

:rainbow: :lollipop: Themes :candy: :heart_eyes: for Alacritty: A cross-platform GPU-accelerated Terminal emulator
MIT License
696 stars 71 forks source link

Permission to add a theme #62

Closed tiagaoalb closed 2 years ago

tiagaoalb commented 2 years ago

I would like to have permission to add a theme.

I already cloned and added the palenight.yml locally. If thats ok of course.

If that is not possible, could you add a Palenight theme?

JuanVqz commented 2 years ago

Sure! Open a PR, please.

tiagaoalb commented 2 years ago

Sure! Open a PR, please.

I can't because I don't have permission.

JuanVqz commented 2 years ago

I'm just guessing, did you clone the https://github.com/rajasegar/ alacritty-themes repository instead of fork it?

JuanVqz commented 2 years ago

  1. image

  2. it will create a cloned repo in your Github account something like https://github.com/tiagaoalb/alacritty-themes then you can clone it in you machine

  3. create a branch, then make your code (add the theme you want to add to the alacritty-themes repo)

  4. push it to GitHub, you should see an alert asking you to create a Pull Request into rajasegar/alacritty-themes then you create it ant that's all.

tiagaoalb commented 2 years ago

I'm just guessing, did you clone the https://github.com/rajasegar/ alacritty-themes repository instead of fork it?

Yes..., ok.

tiagaoalb commented 2 years ago

@JuanVqz, waiting your CR.

rajasegar commented 2 years ago

:tada: This issue has been resolved in version 4.1.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: