RDD API - top() and take_ordered()

rajasekarv / vega

A new arguably faster implementation of Apache Spark from scratch in Rust

Apache License 2.0

2.23k stars 207 forks source link

RDD API - top() and take_ordered() #114

Closed ugoa closed 4 years ago

ugoa commented 4 years ago

Implemented #94
Implemented #95

ugoa commented 4 years ago

@rajasekarv @iduartgomez I did a try on the this 2 APIs, but with my limited Rust knowledge the code might look a bit repetitive. I've highlighted the parts that I think worth refactoring. Please help review them and let me know your thoughts. Cheers.

iduartgomez commented 4 years ago

For the next time, would be even better to do one PR per issue so we can connect each PR with a certain issue/feature. Will review shortly.

iduartgomez commented 4 years ago

Perfect now, do you want to make any other changes or we can merge it?

ugoa commented 4 years ago

No more changes, ready to merge. Thanks!