search

rajasekarv / vega

A new arguably faster implementation of Apache Spark from scratch in Rust
Apache License 2.0
2.23k stars 205 forks source link

Clippy run #14

Closed iduartgomez closed 4 years ago

iduartgomez commented 4 years ago

Fixed the clippy error lints so people with clippy on can at least build and removed a few of the most glaring warnings to make things more idiomatic.

Ran the tests plus the examples to see there is no problem (I advice though that having more testings and a CI pipeline up to be one of the first things to do, like things are now refactors are hard.)

There still are 60+ warnings but I saw a lot of comments and 'to be implemented' stuff and fixing some of these may require further refactoring, so left those for now.

Closes #13

iduartgomez commented 4 years ago

Fixed the 3 issues.

rajasekarv commented 4 years ago

thanks @iduartgomez