search

rajatjindal / goodfirstissue

webhook for goodfirstissue github app
https://github.com/apps/goodfirstissue
Apache License 2.0
31 stars 7 forks source link

add unit tests for goodfirstissue #23

Open rajatjindal opened 5 years ago

rajatjindal commented 5 years ago

add unit tests for goodfirstissue

AdamT213 commented 5 years ago

I would like to work on this if you have not done so already. This is a really cool idea!

rajatjindal commented 5 years ago

Hi Adam,

thanks for taking the initiative.

sure go ahead. Let me know if I can help in someway.

Thanks Rajat Jindal

AdamT213 commented 5 years ago

I apologize for jumping the gun too quickly. Should have looked the repo over more closely. I'm not really familiar with golang so not sure I could make a meaningful contribution right now.

Ewocker commented 5 years ago

@rajatjindal It is currently not straight forward to write unit test for handler.go because of the golang submodule import. see https://github.com/openfaas/faas-cli/issues/324 There are couple of options listed in the above issue, but I am not sure which one is suitable for this case. The easy way to go with will be not using any sub-modules, but it might not be the best solution.

rajatjindal commented 5 years ago

I see. may be we refactor it to use Dockerfile template to fix this issue.