rajatjindal / goodfirstissue

webhook for goodfirstissue github app
https://github.com/apps/goodfirstissue
Apache License 2.0
31 stars 7 forks source link

[experimental] Slack integration #26

Closed rajatjindal closed 5 years ago

rajatjindal commented 5 years ago

ability to send msg to slack channels on good-first-issue.slack.com

rajatjindal commented 5 years ago

@ewocker, can you please review.

rajatjindal commented 5 years ago

Thanks Alex.

I explored using incoming webhook, the prob with that is u need a webhook per channel?

There was another lib which was creating websockets, i will cross check if this one create that as well. I think this one just make http post request without creating websockets

The idea behind this integration is to have a channel per project/org so that ppl can join/subscribe to channels they are interested in. (Twitter can get overwhelming if there are too many projects)

On Sun, Apr 28, 2019 at 3:23 PM Alex Ellis notifications@github.com wrote:

@alexellis commented on this pull request.

Added a comment

In goodfirstissue/slack/slack.go https://github.com/rajatjindal/goodfirstissue/pull/26#discussion_r279186436 :

+) + +var credentialsFile = "/var/openfaas/secrets/slack.yaml" + +//Tokens is for slack tokens +type Tokens struct {

  • Token string yaml:"token" +}
  • +//Client is slack client +type Client struct {

  • slack *slack.Slack +}
  • +//NewClient returns new twitter client +func NewClient() (*Client, error) {

Given that the function isn't guaranteed to be persistent, make sure you don't establish any websockets. I post messages to Slack simply by using a HTTP post and the appropriate incoming webhook URL.

You are also tweeting, so IFTTT can be used to forward the tweets to Slack as an alternative.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rajatjindal/goodfirstissue/pull/26#pullrequestreview-231459264, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEVN7HZUFOL765DVRK3QBTPSVXYFANCNFSM4HI56XLA .

-- Rajat Jindal | Pune | https://rajatjindal.com | rajatjindal83@gmail.com