Closed guessi closed 2 years ago
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | 093539fb2d7a3bd3629210b984add3de37410071 |
Hi @rajatjindal, thank you for creating krew-release-bot
which is helpful for krew
community.
Btw, I'm aware there was a comment under pr12 back in 2020 explained why keeping vendor/
, but it would be nice to utilize go modules. I also tried to minimized go.{mod,sum}
, hope it could reduce the time spent for packages downloading.
It would be nice if you have some time to review this PR. Thanks!
fyi, it would be easier to review via TAB: commits, I've split my commits into several topics.
Out of curiosity: why remove vendor?
Out of curiosity: why remove vendor?
Simply trying to make source tree clear and reduce diff-lines for the following commits.
I think I should leave it to original author @rajatjindal to decide when to upgrade packages and how to manage packages. So I decided to revert commits for package version changes.
Commits still available here at my personal fork.
thanks a lot for your PR
golang 1.17
andalpine 3.15
.gitignore
to prevent sensitive data being packed into docker imagePR build
Test