rajatjindal / krew-release-bot

bot to bump version of plugin in krew-index on new releases
Apache License 2.0
46 stars 16 forks source link

Fix golang version not aligned at .github/workflows #62

Closed guessi closed 2 years ago

guessi commented 2 years ago

PR build

% go version
go version go1.17.7 darwin/amd64

% go run ./cmd/action/
krew-release-bot is a Github Action for updating plugin manifests in Krew Index repo

Usage:
  krew-release-bot [command]

Available Commands:
  action      github action for updating plugin manifests in krew-index repo
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  template    template helps validate the krew index template file without going through github actions workflow

Flags:
  -h, --help   help for krew-release-bot

Use "krew-release-bot [command] --help" for more information about a command.

% go run ./cmd/action/ help action
github action for updating plugin manifests in krew-index repo

Usage:
  krew-release-bot action [flags]

Flags:
  -h, --help   help for action

Test

% go test ./... -cover
?       github.com/rajatjindal/krew-release-bot/cmd/action  [no test files]
?       github.com/rajatjindal/krew-release-bot/cmd/webhook [no test files]
?       github.com/rajatjindal/krew-release-bot/pkg/cicd    [no test files]
ok      github.com/rajatjindal/krew-release-bot/pkg/cicd/circleci   0.259s  coverage: 81.5% of statements
ok      github.com/rajatjindal/krew-release-bot/pkg/cicd/github 0.481s  coverage: 65.4% of statements
ok      github.com/rajatjindal/krew-release-bot/pkg/cicd/travisci   0.718s  coverage: 61.5% of statements
ok      github.com/rajatjindal/krew-release-bot/pkg/krew    0.732s  coverage: 76.5% of statements
?       github.com/rajatjindal/krew-release-bot/pkg/releaser    [no test files]
ok      github.com/rajatjindal/krew-release-bot/pkg/source  25.053s coverage: 77.2% of statements
ok      github.com/rajatjindal/krew-release-bot/pkg/source/actions  25.287s coverage: 48.1% of statements
netlify[bot] commented 2 years ago

Deploy request for inspiring-brown-e0fe87 pending review.

Visit the deploys page to approve it

Name Link
Latest commit 093539fb2d7a3bd3629210b984add3de37410071
guessi commented 2 years ago

Hi @rajatjindal, thank you for creating krew-release-bot which is helpful for krew community.

Btw, I'm aware there was a comment under pr12 back in 2020 explained why keeping vendor/, but it would be nice to utilize go modules. I also tried to minimized go.{mod,sum}, hope it could reduce the time spent for packages downloading.

It would be nice if you have some time to review this PR. Thanks!

guessi commented 2 years ago

fyi, it would be easier to review via TAB: commits, I've split my commits into several topics.

ahmetb commented 2 years ago

Out of curiosity: why remove vendor?

guessi commented 2 years ago

Out of curiosity: why remove vendor?

Simply trying to make source tree clear and reduce diff-lines for the following commits.

guessi commented 2 years ago

I think I should leave it to original author @rajatjindal to decide when to upgrade packages and how to manage packages. So I decided to revert commits for package version changes.

Commits still available here at my personal fork.

rajatjindal commented 2 years ago

thanks a lot for your PR