search

rajatomar788 / pywebcopy

Locally saves webpages to your hard disk with images, css, js & links as is.
https://rajatomar788.github.io/pywebcopy/
Other
531 stars 106 forks source link

Added minor .github changes #6

Closed maxpearl closed 5 years ago

maxpearl commented 5 years ago

I'm a Pipenv user, so I added Pipfiles. I also wanted git to ignore my testing directory.

maxpearl commented 5 years ago

I realize perhaps I should have added this to the Beta branch - it seemed you were working on master now. Let me know.

rajatomar788 commented 5 years ago

The beta branch is actually for the new version i.e. v6. So I think rewritten files of the new version aren't compatible with the current master branch version i.e. v5. Thats just silly naming mistake on my side.

I was working the Beta branch since the current master branch doesn't have much to improve. So I think I should be pulling your request then creating a new Tag and then bringing the Beta branch as master.?? What do you think??

P. S. I live in +5:30 timezone so may be slow to respond.

rajatomar788 commented 5 years ago

P. S. Can you test that whether the the new master branch files are working as they should. I am not near a pc for now.

maxpearl commented 5 years ago

Sorry this took me so long - I've been swamped. Master branch seems to work as they should so far. If I run into anything, I'll submit a ticket (or fix.)

rajatomar788 commented 5 years ago

Okay

On Tue, May 7, 2019, 2:05 AM Max Pearl notifications@github.com wrote:

Sorry this took me so long - I've been swamped. Master branch seems to work as they should so far. If I run into anything, I'll submit a ticket (or fix.)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/rajatomar788/pywebcopy/pull/6#issuecomment-489766680, or mute the thread https://github.com/notifications/unsubscribe-auth/AIGSNTQ7GYP6P4YG66ZCKGTPUCI7ZANCNFSM4HJO7KYQ .