search

rajatomar788 / pywebcopy

Locally saves webpages to your hard disk with images, css, js & links as is.
https://rajatomar788.github.io/pywebcopy/
Other
527 stars 106 forks source link

elements.py: stash quotes/apostrophes for enquoted urls #73

Closed NickVeld closed 2 years ago

NickVeld commented 3 years ago

Fixes many pretty strange consequent problems caused by interfering into the head and tail checks by the quotes

NickVeld commented 3 years ago

I do not know why there are 3 broken tests instead of usual 1. But all of them are with the same exception.

NickVeld commented 3 years ago

Any Ideas? Have you restarted them?

rajatomar788 commented 2 years ago

Hey @NickVeld can you check whether this fix is still relevant to the new release version 7.

NickVeld commented 2 years ago

Hi As I understand, in 7.0+ the quotes is just removed. In turn, this PR saves the quotes in the string after replacement.

rajatomar788 commented 2 years ago

Hey @NickVeld Sorry for being this late but can you please check the relevance of this pr to the current version else this pr should be closed. Same for the other one I just closed .

NickVeld commented 2 years ago

Hey @rajatomar788 Everything has changed a lot. Maybe the issue still persists but it cannot be fixed with this PR anyway :(