search

rajatthareja / ReportBuilder

Ruby gem to merge Cucumber JSON reports and build mobile-friendly HTML Test Report, JSON report and retry file.
https://reportbuilder.rajatthareja.com
MIT License
81 stars 47 forks source link

Use params for ERB.new per deprecation warning #106

Closed phebus closed 2 years ago

phebus commented 2 years ago

Ruby 3.1 is throwing these deprecation warnings for ERB.new. 

gems/report_builder-1.9/lib/report_builder/builder.rb:67: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
gems/report_builder-1.9/lib/report_builder/builder.rb:67: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
gems/report_builder-1.9/lib/report_builder/builder.rb:67: warning: Passing eoutvar with the 4th argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, eoutvar: ...) instead.

This uses the eoutvar param (as the other params are nil) to rectify. I ran the specs in ruby 2.7 and 3.1 and they both passed. If you believe there should be other tests added please let me know, but I think this private method gets covered in the existing tests

phebus commented 2 years ago

So this failed tests because it appears it runs against ruby 2.3 and 2.5? Both of those are out of service. Is there any way we can run them against 2.7 and 3+? Also are you still maintaining this repo @rajatthareja ?

enkessler commented 2 years ago

@phebus Those older versions of Ruby are out of service, yes, but we can still run them in CI and maintaining compatibility is easy enough until this gem drops support for those versions. When that might happen, I've no idea. I tried contacting @rajatthareja on the most recent email addresses that I could find but have not heard back.