search

rajdeep / proton

Purely native and extensible rich text editor for iOS and macOS Catalyst apps
Other
1.26k stars 81 forks source link

Native visionOS Support #267

Closed bryan1anderson closed 7 months ago

bryan1anderson commented 8 months ago

Just a note.. the tests cannot be run on visionOS as SnapshotTesting does not support it.

I verified this in my own project. The only issue is this..

inputAccessoryView is not available from within visionOS. This required an OS check within my own project.

class MyEditorView: EditorView {
    var toolbarDelegate: MyToolbarDelegate?
#if !os(visionOS)
    override var inputAccessoryView: UIView? {
        let toolbar = MyToolbar(frame: .zero)
        toolbar.myDelegate = toolbarDelegate
        return toolbar
    }
#endif
}
rajdeep commented 7 months ago

@bryan1anderson, I have made some changes in Proton. Would you please update your PR with the latest changes in Proton. The PR should go green after that and we'll be good to merge it. I'll also make a release as soon as I merge this PR so that it is available for you to use. Once again, thanks for your help with this.

rajdeep commented 7 months ago

@bryan1anderson, I have also created a PR with your changes yesterday but for some reason, a particular test is failing on Github. I'll be trying to fix that and get the same merged soon. Once that is merged, I'll close this PR. You can track that here: #272

rajdeep commented 7 months ago

merged as part of #272