search

rajdeep / proton

Purely native and extensible rich text editor for iOS and macOS Catalyst apps
Other
1.25k stars 81 forks source link

Xcode issue #308

Closed easiwriter closed 2 months ago

easiwriter commented 2 months ago

I've just upgraded to v15.4 and hit a problems compiling Proton related code. I'm getting the message:

Type 'AttributedTextView.Coordinator' cannot conform to protocol 'EditorViewDelegate' because it has requirements that cannot be satisfied. The Coordinator is a class required by UIViewRepresentatble.

I haven't changed my code so can't work out what this means. What requirements might it refer to?

I've also noticed that I've for v0.8.35 installed though this site says 0.8.33.1 is the latest?

easiwriter commented 2 months ago

Well, it just went away on the next compilation attempt!!

easiwriter commented 2 months ago

Although it now compiles it throws up a runtime error with the same message. (It hangs the moment I try and open the editor, so I added the break to work out why)

rajdeep commented 2 months ago

@easiwriter, would it be possible for you to provide a sample project showing this issue? That might help me look into it at the correct place.

Also, 0.8.35 is the latest. 0.8.33.1 was a patch created on top of 0.8.33 which would not have all the changes from 0.8.34 and 0.8.35.

easiwriter commented 2 months ago

Thanks for the reply. The compilation problem went away again and hasn’t returned. However, the code suddenly started looping as soon as it tried to load an editor window. I’ve just spent a day tracking this down. It’s nothing to do with Proton, rather SwiftUI has apparently tightened up its rules for tracking view updates, the result in this case being that it keeps seeing my editor view as changed. I know what’s doing it and am rather fed up with Apple for making changes that affect code that’s worked for a couple of years. Not only that but the DisclosureGroup view also stopped working properly. Being a developer is hard enough without these (undocumented) changes to the undergrowth!

(Rant over)

Cheers Keith

On 22 May 2024, at 00:54, Rajdeep Kwatra @.***> wrote:

@easiwriter https://github.com/easiwriter, would it be possible for you to provide a sample project showing this issue? That might help me look into it at the correct place.

Also, 0.8.35 is the latest. 0.8.33.1 was a patch created on top of 0.8.33 which would not have all the changes from 0.8.34 and 0.8.35.

— Reply to this email directly, view it on GitHub https://github.com/rajdeep/proton/issues/308#issuecomment-2123608784, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEUXIA25UW7SITIHJH7SNBDZDPNETAVCNFSM6AAAAABIBTMXPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTGYYDQNZYGQ. You are receiving this because you were mentioned.

rajdeep commented 2 months ago

@easiwriter, I hear you. There have always been these challenges and some do not even make sense but oh well, we can just hope things get better with time.

I'm closing this issue. Please feel free to open this again should you find something that may still need to be looked at.