search

rajdeep / proton

Purely native and extensible rich text editor for iOS and macOS Catalyst apps
Other
1.25k stars 81 forks source link

Shared UIMenuController #313

Closed easiwriter closed 1 month ago

easiwriter commented 1 month ago

Does Proton support the sharedMenuController? I want to add the edit popup to my app and have used this in another app. I know that UIMenuController is now deprecated in favour of UIEditMenuInteraction. If Proton doesn't support what would be the best way to implement it?

easiwriter commented 1 month ago

I have tried to implement this using UIEditMenuInteraction but failed because I can't get hold of the UITextView inside RichTextView as it's declared as internal. Any chance you could provide a getter for it?

rajdeep commented 1 month ago

@easiwriter, RichTextView cannot be exposed outside as it can cause a lot of unintended side-effects. However, I have updated the EditorView to add support for adding interaction in #314 and has merged it in. I'll be creating a release in a few days as I need to fix certain things with the ongoing work with tables. You should still be able to point to the latest commit to use the new API.

easiwriter commented 1 month ago

Excellent. Many thanks.

On 20 Jun 2024, at 08:40, Rajdeep Kwatra @.***> wrote:

@easiwriter https://github.com/easiwriter, RichTextView cannot be exposed outside as it can cause a lot of unintended side-effects. However, I have updated the EditorView to add support for adding interaction in #314 https://github.com/rajdeep/proton/pull/314 and has merged it in. I'll be creating a release in a few days as I need to fix certain things with the ongoing work with tables. You should still be able to point to the latest commit to use the new API.

— Reply to this email directly, view it on GitHub https://github.com/rajdeep/proton/issues/313#issuecomment-2180022971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEUXIAYTULFV3IH624YEZ3TZIKBPXAVCNFSM6AAAAABJN4HQD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGAZDEOJXGE. You are receiving this because you were mentioned.