codepathreview
commented
8 years ago :+1: Project looks good, glad you were able to finish all required stories
- Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ!
- Good to see you properly communicated the user to the user timeline fragment from the profile activity.
- Nice to see you used the ViewPager to properly setup the tabs!
- Consider adding progress bars to your app whenever a network request goes out
- Try to implement more optional features so that you will get to play with more widgets and understand complexities involved
- In the future, definitely consider additional polish for the UI by reviewing the cloning a screen tutorial and Q&A and the drawables guide
We have provided a detailed Twitter Redux Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.
/cc @codepathreview @codepath