rajeshvaya / Sublime-Extended-Tab-Switcher

View all open files (sorted/unsorted) for switching between them.
MIT License
26 stars 10 forks source link

cannot open quick panel while having "Find Results" tab opened #6

Closed revlis7 closed 9 years ago

revlis7 commented 9 years ago

After doing a search in the project files. I can't open the quick panel by shortcut keys until I close the "Find Results" tab. Here is the error message:

Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 524, in run_
    return self.run(**args)
  File "ExtendedSwitcher in /Users/kevin/Library/Application Support/Sublime Text 3/Installed Packages/ExtendedTabSwitcher.sublime-package", line 55, in run
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime.py", line 352, in show_quick_panel
    flat_items.append(items[i][j])
IndexError: list index out of range
rajeshvaya commented 9 years ago

Just wanted to make sure you have installed the plugin using the package manager (https://sublime.wbond.net/packages/ExtendedTabSwitcher) and have the latest version 2.3.0?

revlis7 commented 9 years ago

Yes, installed by package control and version is 2.3.0

rajeshvaya commented 9 years ago

ok, can you send me your configurations for this plugin I want to reproduce with the same configs as you have

revlis7 commented 9 years ago

I didn't change anything for ExtendedTabSwitcher, "Settings" and "Key Bindings" files are blank.

BTW, I also have some other plugin installed:

Git Rsync SSH SideBarEnhancements

btsai commented 9 years ago

I'm not sure why Sublime is handling Find Results differently, but if you change this line:

https://github.com/rajeshvaya/Sublime-Extended-Tab-Switcher/blob/master/ExtendedSwitcher.py#L44

from

else

to

elif f.name() != 'Find Results':

This will fix the error and show the files dialog.

dmyger commented 9 years ago

1) Set "show_full_file_path": false also helps. But: you can't see a file's path or 2) add empty second argument see line 45 in ExtendedSwitcher.py from self.open_files.append([f.name(),]) to self.open_files.append([f.name(),'']) But: it does not work if first tab is 'Find Results'

rajeshvaya commented 9 years ago

Thanks to @qsvui this should be fixed. I have tagged another release (2.3.1) and should be updated soon in the package control as well