rajewsky-lab / novosparc

BSD 3-Clause "New" or "Revised" License
125 stars 41 forks source link

Repeatability #34

Closed Counts-Xin closed 4 years ago

Counts-Xin commented 4 years ago

sorry to bother you, I get different results with same code in different runs, that is I cannoot get the repeatable results, especially without marker genes information.

nukappa commented 4 years ago

Do you use the same number of cells and genes every time? If yes, the results should be reproducible. If you change any parameters like number of cells, number of locations, number of genes used, geometry etc., the reconstructions would be of course different.

mjang2000 commented 4 years ago

I have also not been able to repeatable results. Every time I run the tutorial notebook, I get the same results as my previous runs, but the results are not the same as the results in the tutorial notebook. I realized that the files are not named exactly the same, so I substituted missing files for the closest file (i.e. "high_var_genes.txt" instead of "hvg.txt" for the "reconstruct_drosophila_embryo_tutorial.ipynb" notebook), but other than that, I have not changed anything. I was wondering why this may be the case.

patrickaoude commented 4 years ago

mjang2000, I had similar issues.

Please take a look at my pull request and see if it helps: https://github.com/rajewsky-lab/novosparc/pull/21

nukappa commented 4 years ago

@mjang2000 @patrickaoude Thanks, we'll check this.

enessenel commented 4 years ago

https://github.com/rajewsky-lab/novosparc/pull/21 is merged now and the tutorial is updated with f651f2309732861625a79686618a71f393a8c359 for the correct reconstruction with marker genes. @patrickaoude thanks for the contribution!